-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle line advancement when parsing AnchorPrefix and TagPrefix #368
Labels
bug
Something isn't working
Comments
@alienczf |
all good. though i've decided to give up on yaml in cpp and have some
external script to do a conversion into json first. upon further digging,
it seems like for really large yaml files: anchors and tags are not fully
preserved. I've done some debugging locally and noticed that when the
element is first parsed the fields are attached correctly, but when the
final document is returned the attributes go missing. I've not done a full
trace because the document is a bit too large to trace easily and i'm not
familiar enough with this codebase to set the right conditional breakpoints
…On Tue, Jul 16, 2024 at 8:31 PM fktn ***@***.***> wrote:
@alienczf <https://github.com/alienczf>
Thanks for filing the issue.
I'll take a look later.
The fix will be available hopefully this weekend (I'll be unavailable this
weekdays).
—
Reply to this email directly, view it on GitHub
<#368 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AECBFFUSQLWEHFHJOS3V3TLZMUHDRAVCNFSM6AAAAABK56LMDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZQG43TCOJZGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
4 tasks
fktn-k
added a commit
that referenced
this issue
Aug 17, 2024
* fixed lacked line advancement for block mappings as a block sequence entry * run amalgamation * cleaned up redundant impl for node traversals before parsing a mapping key node * modified comments for parsing node props
No worries, thanks for the update!
…On Sat, 17 Aug 2024, 11:51 fktn, ***@***.***> wrote:
@alienczf <https://github.com/alienczf>
Sorry for replying too late.
I've finally got enough time to investigate the root cause of the reported
bug and fixed it with some related bugs which were also found during the
investigation (PR #369 <#369>).
The fixed version of this library is now available in the develop branch.
—
Reply to this email directly, view it on GitHub
<#368 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AECBFFR5ZU7WUFRQOGLHLS3ZR3CCVAVCNFSM6AAAAABK56LMDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJUGYYTCMBSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I'll close this issue since the reported bug has been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
when parsing anchor_prefix and tag prefix, the code currently doesn't advance line if we happend to consume newline character.
this results in the subsequent tokens being labelled with wrong line number
Reproduction steps
sample.yaml
Expected vs. actual results
wrongly throws indentation error
Minimal code example
No response
Error messages
No response
Compiler and operating system
clang17 ubuntu22
Library version
develop
Validation
develop
branch is used.The text was updated successfully, but these errors were encountered: