Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed parsing UTF-16 encoded inputs which do not end with a surrogate… #234

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Dec 2, 2023

This PR fixed a bug in parsing UTF-16 encoded inputs reported in #233.
Also, the test suite has been modified to ensure the change works as expected.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Dec 2, 2023
@fktn-k fktn-k added this to the Release v0.2.3 milestone Dec 2, 2023
@fktn-k fktn-k self-assigned this Dec 2, 2023
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling cd8f3e5 on bugfix/233_fix_parsing_utf16_inputs
into e02af6b on develop.

@fktn-k fktn-k merged commit be5f638 into develop Dec 2, 2023
104 checks passed
@fktn-k fktn-k deleted the bugfix/233_fix_parsing_utf16_inputs branch December 2, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants