-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#292 Better handling for flow indicators in permitted scalar contexts #293
#292 Better handling for flow indicators in permitted scalar contexts #293
Conversation
dd9dde2
to
c82b165
Compare
c82b165
to
0180600
Compare
c00d379
to
a2ed943
Compare
As you can see, there's a fair bit of noise on this PR from me tweaking the tests to ensure proper coverage, and forgetting to run the amalgamation script a time or two. Serves me right for working late ;) |
@stephenwhittle Rather, I'm sorry for not mentioning the way of checking test coverage in the CONTRIBUTING.md,
Regarding this one, I honestly don't know at all... |
@stephenwhittle
I've confirmed that the above steps do nothing to the upstream repository. |
…le code; add additional tests
dcfdeda
to
3cc8101
Compare
A few notes @fktn-k -
|
@stephenwhittle
This happens to me as well... (I got a 504 (timeout) error. The same on your end?)
That's more reasonable. I agree with the change to make it less prone to errors, like replacing
Agree. I made some workarounds to avoid such issues before (I just recalled that). There should be some option to keep the compiler from expanding any functions inline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks a lot, @stephenwhittle.
This PR addresses #292 by checking if the lexer is in a flow context before treating flow indicators, commas, or colons as terminating plain unquoted strings.
Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdef
s or other means.