Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improvements of input handlings #301

Merged
merged 7 commits into from
Mar 30, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Mar 30, 2024

This PR has improved input handling, as additional works which are untouched in #296.
The following changes have been made:

  • input_handler::test_next_char() function has been replaced with input_handler::peek_next() function to more generally access the next input character without moving the current position.
  • Preparation of buffers to be filled with input characters have been improved by reducing the number of calls during the initialization process of the lexer for optimization purposes.
  • String manipulation in the lexer has been optimized.

Note that the public APIs are not affected by the above changes.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the improvement refactoring or optimization without public API changes label Mar 30, 2024
@fktn-k fktn-k added this to the Release v0.3.3 milestone Mar 30, 2024
@fktn-k fktn-k self-assigned this Mar 30, 2024
Copy link

github-actions bot commented Mar 30, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit a131c094e4d0a08d1b4682e54a280ecfba666719.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr301.zip
ID 1371740046
URL https://github.com/fktn-k/fkYAML/actions/runs/8492707297/artifacts/1371740046

@coveralls
Copy link

coveralls commented Mar 30, 2024

Pull Request Test Coverage Report for Build 8492707297

Details

  • 287 of 287 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8477959635: 0.0%
Covered Lines: 3046
Relevant Lines: 3046

💛 - Coveralls

@fktn-k fktn-k merged commit cb95548 into develop Mar 30, 2024
144 checks passed
@fktn-k fktn-k deleted the feature/further_improve_input_handlings branch March 30, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants