Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Valgrind error in the test suite #307

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Apr 9, 2024

This PR has fixed errors reported by Valgrind.
The errors were due to missing std::fclose() calls after opening a test data file in the input_adapter class test cases.
So no changes have been made to the library source codes.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Apr 9, 2024
@fktn-k fktn-k added this to the Release v0.3.4 milestone Apr 9, 2024
@fktn-k fktn-k self-assigned this Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 7988d1c8dc28cd098d4e46ccd9fd8032a83b9a5d.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr307.zip
ID 1398333619
URL https://github.com/fktn-k/fkYAML/actions/runs/8618357114/artifacts/1398333619

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8618357114

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8602833627: 0.0%
Covered Lines: 3464
Relevant Lines: 3464

💛 - Coveralls

@fktn-k fktn-k merged commit 6f45be2 into develop Apr 9, 2024
143 checks passed
@fktn-k fktn-k deleted the fix_valgrind_error_in_test_suite branch April 9, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants