Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#294 Support std::basic_string_view #313

Merged
merged 4 commits into from
Apr 20, 2024
Merged

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Apr 20, 2024

This PR has added the std::basic_string_view support in the conversion from a string node to a native string value only when compiled with C++17 or better.
Also, test cases for the deserialization feature have been added for the explicit support for the std::basic_string_view<CharT> types.
The documentation has also been updated according to the above changes.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the new feature new feature possibly with public API changes label Apr 20, 2024
@fktn-k fktn-k added this to the Release v0.3.4 milestone Apr 20, 2024
@fktn-k fktn-k self-assigned this Apr 20, 2024
Copy link

github-actions bot commented Apr 20, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 1458ff982f100efd8de4bab46872696afc8c45d2.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr313.zip
ID 1431468753
URL https://github.com/fktn-k/fkYAML/actions/runs/8762347300/artifacts/1431468753

@fktn-k fktn-k force-pushed the feature/294_support_string_view branch from b511b64 to 1458ff9 Compare April 20, 2024 03:42
@fktn-k fktn-k merged commit 3f10411 into develop Apr 20, 2024
154 checks passed
@fktn-k fktn-k deleted the feature/294_support_string_view branch April 20, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature new feature possibly with public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant