Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parse error on the first node which isn't a block mapping #322

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Apr 26, 2024

fkYAML in the latest develop branch emits a parse error when an input buffer starts with a node which is not a block mapping, like the following valid YAML snippets:
(block sequence)

- 123
- foo
- 3.14

(flow sequence)

[123, foo, 3.14]

(flow mapping)

{foo: 123, true: 3.14}

So, this PR has fixed the error and added some test cases to validate the changes.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Apr 26, 2024
@fktn-k fktn-k added this to the Release v0.3.5 milestone Apr 26, 2024
@fktn-k fktn-k self-assigned this Apr 26, 2024
Copy link

github-actions bot commented Apr 26, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 7035aafeeb8ec4359f0b3800257f761af521f43a.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr322.zip
ID 1450948658
URL https://github.com/fktn-k/fkYAML/actions/runs/8849043964/artifacts/1450948658

@coveralls
Copy link

coveralls commented Apr 26, 2024

Pull Request Test Coverage Report for Build 8849043964

Details

  • 22 of 22 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8835266680: 0.0%
Covered Lines: 3544
Relevant Lines: 3544

💛 - Coveralls

@fktn-k fktn-k merged commit 915f1df into develop Apr 26, 2024
154 checks passed
@fktn-k fktn-k deleted the parse_first_non_block_mapping_node branch April 26, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants