Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed no such file/directory error when running Bash scripts on Windows #328

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Apr 28, 2024

When the Bash scripts for running clang-format and amalagamation on Windows, they ends up with errors which says no such file/directory.
This is because (1) Python distributions for Windows have no python3 executable and (2) binaries are stored in the venv\Scripts directory, not in the venv/bin directory, when Python venv module is used on Windows.
To fix the above issues, this PR has added platform switches using the output from the uname command.
Both on Ubuntu22.04 with WSL2 and Windows10 with Git for Windows (2.44.0-windows.1), the scripts now work as expected.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added this to the Release v0.3.6 milestone Apr 28, 2024
@fktn-k fktn-k self-assigned this Apr 28, 2024
@fktn-k fktn-k merged commit 6eeed6d into develop Apr 28, 2024
6 checks passed
@fktn-k fktn-k deleted the fix_bash_scripts_for_windows_platforms branch April 28, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant