Fixed no such file/directory error when running Bash scripts on Windows #328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Bash scripts for running clang-format and amalagamation on Windows, they ends up with errors which says no such file/directory.
This is because (1) Python distributions for Windows have no
python3
executable and (2) binaries are stored in thevenv\Scripts
directory, not in thevenv/bin
directory, when Python venv module is used on Windows.To fix the above issues, this PR has added platform switches using the output from the
uname
command.Both on Ubuntu22.04 with WSL2 and Windows10 with Git for Windows (2.44.0-windows.1), the scripts now work as expected.
Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdef
s or other means.