Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate YAML escaping/unescaping functionalities #337

Merged
merged 2 commits into from
May 3, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented May 3, 2024

This PR has created a new module yaml_escaper which executes YAML escaping/unescaping whose functionalities used to be implemented in multiple classes (especially in the lexer and the serializer).
Since this is just a refactoring, the library outputs will not change as I've checked them with the unit testing results.
Furthermore, the related test cases have been moved to the test source for yaml_escaper.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the improvement refactoring or optimization without public API changes label May 3, 2024
@fktn-k fktn-k added this to the Release v0.3.7 milestone May 3, 2024
@fktn-k fktn-k self-assigned this May 3, 2024
Copy link

github-actions bot commented May 3, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 90f41ef2b4734ef797ff19d8fe4cae2b3759ad23.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr337.zip
ID 1470634191
URL https://github.com/fktn-k/fkYAML/actions/runs/8939448137/artifacts/1470634191

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8939448137

Details

  • 272 of 272 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8925561821: 0.0%
Covered Lines: 3599
Relevant Lines: 3599

💛 - Coveralls

@fktn-k fktn-k changed the title Separate yaml encoding functionality Separate YAML escaping/unescaping functionalities May 3, 2024
@fktn-k fktn-k merged commit d949136 into develop May 3, 2024
162 checks passed
@fktn-k fktn-k deleted the separate_yaml_encoding_functionality branch May 3, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants