Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parse error on flow containers containing child flow containers #345

Merged
merged 1 commit into from
May 19, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented May 19, 2024

This PR has fixed parse errors on flow style containers which contains child flow style containers like the following valid JSON-like YAML snippet:

{
  "a": [
    "foo",
    "bar"
  ],
  "b": [
    [
      true,
      false
    ],
    [
      123,
      456
    ]
  ]
}

The root cause is that the fkYAML deserializer didn't properly handle nested flow style container prefix events.
To validate the fix, the test suite has also been updated by adding several test cases for the deserialization feature.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label May 19, 2024
@fktn-k fktn-k added this to the Release v0.3.8 milestone May 19, 2024
@fktn-k fktn-k self-assigned this May 19, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit c91ac69faf8a73a55309559efed7ce8be6ff8a72.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr345.zip
ID 1517137061
URL https://github.com/fktn-k/fkYAML/actions/runs/9148221027/artifacts/1517137061

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9148221027

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9147143461: 0.0%
Covered Lines: 3752
Relevant Lines: 3752

💛 - Coveralls

@fktn-k fktn-k merged commit e3c34b1 into develop May 19, 2024
160 checks passed
@fktn-k fktn-k deleted the fix_parse_nested_flow_containers branch May 19, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants