Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed parse error on explicit mappings as a block sequence entry #353

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Jun 1, 2024

This PR has fixed parse errors on explicit mappings as a block sequence entry like the following valid YAML snippet:

- ? foo: 123
  : bar: true
- ? - baz
  : - null

The root cause was that the fkYAML parser just didn't assume explicit mappings as a block sequence entry.
So, implementation has been added for such nodes with some update of the test suite which validates the functionality.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added this to the Release v0.3.9 milestone Jun 1, 2024
@fktn-k fktn-k self-assigned this Jun 1, 2024
@fktn-k fktn-k added the bug Something isn't working label Jun 1, 2024
Copy link

github-actions bot commented Jun 1, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 280c76c1912345f99e4c1c6027a15923c13de334.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr353.zip
ID 1558584594
URL https://github.com/fktn-k/fkYAML/actions/runs/9328722128/artifacts/1558584594

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9328722128

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9326939126: 0.0%
Covered Lines: 3901
Relevant Lines: 3901

💛 - Coveralls

@fktn-k fktn-k merged commit 4b2329d into develop Jun 1, 2024
166 checks passed
@fktn-k fktn-k deleted the fix_parse_error_on_explicit_map_as_seq_entry branch June 1, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants