Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for optimization #356

Merged
merged 8 commits into from
Jun 5, 2024
Merged

Refactor for optimization #356

merged 8 commits into from
Jun 5, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Jun 5, 2024

In this PR, some refactorings have been made for better performance, including:

  • cleaning up basic_node's destructor
  • optimizing the process of scanning multiline scalars
  • improving the scanning of scalar contents for type detection

Also, the Make target for benchmarking contains a wrong fixed path and performance of debug builds were not correctly measured.
However, the performance of debug builds seems to need some more work for trustworthy results, which is why the performance data of debug builds have been removed (possibly revoked in the future).


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the improvement refactoring or optimization without public API changes label Jun 5, 2024
@fktn-k fktn-k added this to the Release v0.3.9 milestone Jun 5, 2024
@fktn-k fktn-k self-assigned this Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit e28350d24a7256c1f24c27d79c7e52b98124a5d4.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr356.zip
ID 1570955087
URL https://github.com/fktn-k/fkYAML/actions/runs/9384349256/artifacts/1570955087

@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9382922992

Details

  • 82 of 82 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 99.98%

Totals Coverage Status
Change from base Build 9340106021: -0.02%
Covered Lines: 3888
Relevant Lines: 3888

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9384349256

Details

  • 82 of 82 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9340106021: 0.0%
Covered Lines: 3888
Relevant Lines: 3888

💛 - Coveralls

@fktn-k fktn-k merged commit ff1fa9b into develop Jun 5, 2024
166 checks passed
@fktn-k fktn-k deleted the refactor_for_optimization branch June 5, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants