Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile errors on Windows #358

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Jun 9, 2024

This PR fixes the following compile errors on Windows:

  • errors from too few template parameters for node_value_converter when compiled with C++20 or newer and Visual Studio 2022, as reported in too few template aruments #357
  • errors from ambiguous parameter type for basic_node::deserialize(ItrType, ItrType) called from the user defined literal operator"" _yaml(...) when compiled with C++11, C++14, C++17 without the /permissive- flag.

Also, workflow jobs have been added to test builds with existing C++ standards and Visual Studio 2022.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Jun 9, 2024
@fktn-k fktn-k added this to the Release v0.3.9 milestone Jun 9, 2024
@fktn-k fktn-k self-assigned this Jun 9, 2024
Copy link

github-actions bot commented Jun 9, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 742a88da0e8f9ca249cf4b09f8e5fd857e9c0ad5.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr358.zip
ID 1583540374
URL https://github.com/fktn-k/fkYAML/actions/runs/9439824568/artifacts/1583540374

@coveralls
Copy link

coveralls commented Jun 9, 2024

Pull Request Test Coverage Report for Build 9439824568

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9384740096: 0.0%
Covered Lines: 3888
Relevant Lines: 3888

💛 - Coveralls

@fktn-k fktn-k merged commit 14d4307 into develop Jun 9, 2024
176 checks passed
@fktn-k fktn-k deleted the fix_too_few_template_arguments branch June 9, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants