Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#366 Fix node-to-float conversion error if node's value is <= 0 #371

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Aug 18, 2024

This PR has fixed the error in converting a node's value into a native floating point value, as reported in the issue #366.
The root cause was that calling the std::min() function to get the minimum possible value of the target type: the function returns minimum possible positive normal value of a floating point value type, not the minimum possible negative value; the appropriate function to call is the std::lowest() for that purpose.
In short, the real cause was the library coudn't convert a node value whose value is a floating point value equal to/less than 0.
So, this PR has fixed the issue by replacing the calling of std::min() with std::lowest() on node-to-float conversions.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Aug 18, 2024
@fktn-k fktn-k added this to the Release v0.3.10 milestone Aug 18, 2024
@fktn-k fktn-k self-assigned this Aug 18, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 0245dc6e103afd89ec8c4728dbb652cc5384488b.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr371.zip
ID 1823943466
URL https://github.com/fktn-k/fkYAML/actions/runs/10437692959/artifacts/1823943466

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10437692959

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10433126801: 0.0%
Covered Lines: 3971
Relevant Lines: 3971

💛 - Coveralls

@fktn-k fktn-k merged commit 0300914 into develop Aug 18, 2024
166 checks passed
@fktn-k fktn-k deleted the bugfix/366_fix_node_to_float_conversion branch August 18, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants