#366 Fix node-to-float conversion error if node's value is <= 0 #371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has fixed the error in converting a node's value into a native floating point value, as reported in the issue #366.
The root cause was that calling the
std::min()
function to get the minimum possible value of the target type: the function returns minimum possible positive normal value of a floating point value type, not the minimum possible negative value; the appropriate function to call is thestd::lowest()
for that purpose.In short, the real cause was the library coudn't convert a node value whose value is a floating point value equal to/less than 0.
So, this PR has fixed the issue by replacing the calling of
std::min()
withstd::lowest()
on node-to-float conversions.Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdef
s or other means.