Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update configs for reuse v4 #372

Merged
merged 2 commits into from
Aug 18, 2024
Merged

update configs for reuse v4 #372

merged 2 commits into from
Aug 18, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Aug 18, 2024

This PR contains changes for maintenance purpose to update versions with the reuse python package.
The reuse has published a major update release (v4) and that contains several breaking changes.
To follow the changes, the following changes are needed in this project as well:

  • replace the deprecated .reuse/dep5 file with the REUSE.toml file to configure licencing informantion
  • use the --style cppsingle option to use the C/C++ comment syle for single lines (//); the --style c option now only supports the C/C++ comment style for multiline comments (/* */), which caused a huge amount of diff lines in updating the library version...

Also, since the Codacy detected a security related issue for Jinja2 (v3.1.2) during the CI processes, Jinja2 version has benn updated to v3.1.4. (The natvis file generator tool depends on Jinja2)


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added this to the Release v0.3.10 milestone Aug 18, 2024
@fktn-k fktn-k self-assigned this Aug 18, 2024
Copy link

github-actions bot commented Aug 18, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 81e23ed249775b40610ee8a185e6e8da5a575b90.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr372.zip
ID 1824105160
URL https://github.com/fktn-k/fkYAML/actions/runs/10438386298/artifacts/1824105160

@coveralls
Copy link

coveralls commented Aug 18, 2024

Pull Request Test Coverage Report for Build 10438386298

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10437861827: 0.0%
Covered Lines: 3971
Relevant Lines: 3971

💛 - Coveralls

@fktn-k fktn-k merged commit 28f64b2 into develop Aug 18, 2024
95 checks passed
@fktn-k fktn-k deleted the update_reuse_configs_for_v4 branch August 18, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants