Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditional branching for pull_request_target events #384

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Aug 22, 2024

This PR fixes conditional branching based on the trigerring event name (pull_request_target or push) to not try to comment to a PR if the triggering event name is push.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the ci related to CI jobs label Aug 22, 2024
@fktn-k fktn-k added this to the Release v0.3.11 milestone Aug 22, 2024
@fktn-k fktn-k self-assigned this Aug 22, 2024
@fktn-k fktn-k merged commit 33d526f into develop Aug 22, 2024
5 checks passed
@fktn-k fktn-k deleted the fix_for_format_coverage_workflows_to_work_on_prs branch August 22, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci related to CI jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant