Handle invalid UTF-8 string members #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some struct members are meant to be UTF-8 encoded strings, but bugs in other software (i.e. clients) can cause them to provide invalid UTF-8 strings. This causes `UnicodeDecodeError` to be raised when decoding these to Python strings. This change prevents these errors so that users of pywlroots don't all need custom logic for bugs in other software.
flacjacket
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some struct members are meant to be UTF-8 encoded strings, but bugs in
other software (i.e. clients) can cause them to provide invalid UTF-8
strings. This causes
UnicodeDecodeErrorto be raised when decodingthese to Python strings. This change prevents these errors so that users
of pywlroots don't all need custom logic for bugs in other software.
--
See qtile/qtile#3161 for more info. Qtile (and other pywlroots-using code) could instead catch the
UnicodeDecodeErrorexceptions themselves as an alternative, or they could usewlroots.ffi.string(obj._member).decode(errors="backslashreplace")directly to avoid doing so. Thoughts?