Improve signal/noise ratio in cron errors

flack · May 28, 2017 · bae7944 · bae7944
1 parent 67d77b2
commit bae7944
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/lib/midcom/baseclasses/components/cron/handler.php b/lib/midcom/baseclasses/components/cron/handler.php
@@ -76,7 +76,6 @@ public function print_error($message, $var = null)
         echo "ERROR ({$class}): {$message}\n";
         debug_add($message, MIDCOM_LOG_ERROR);
         if (!is_null($var)) {
-            print_r($var);
             debug_print_r('Passed argument: ', $var);
         }
     }

diff --git a/lib/midcom/services/at/cron/check.php b/lib/midcom/services/at/cron/check.php
@@ -51,7 +51,7 @@ public function _on_execute()
             $mret = $interface->$method($args, $this);
 
             if ($mret !== true) {
-                $error = get_class($interface) . "->{$method}(\$args, \$this) returned '{$mret}', errstr: " . midcom_connection::get_error_string();
+                $error = get_class($interface) . '->' . $method . '(' . json_encode($args) . ", \$this) returned '{$mret}', errstr: " . midcom_connection::get_error_string();
                 $this->handle_error($entry, $error, $args);
             } else {
                 midcom::get()->auth->request_sudo('midcom.services.at');