Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
linux-capture: Lookup session handle without typechecks
g_variant_lookup() obligatorily receives the type of the variant to lookup. This function is used when retrieving the session handle from the portal's response, and the variant type passed is "s" (a string). However, xdg-desktop-portal had a bug: the documentation explicitly mentions that the session handle is an object path (of variant type "o"), but it passed a string (of variant type "s"). This mismatch was fixed in the xdg-desktop-portal release 1.10 [1], but that broke the PipeWire capture code, which was passing specifically the "s" value to the variant lookup. Fix this by not checking the variant type at all. Object paths ("o") are simply strings with a few extra checks, and we don't actually need to perform these checks. This change probably broke other apps, and that makes me extremely sad :( [1] flatpak/xdg-desktop-portal#609
- Loading branch information