Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing step into installation guide #70

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

amansilla
Copy link
Contributor

@amansilla amansilla commented Nov 12, 2021

Closes: #69, TABATTUP-4

@amansilla amansilla added bug Something isn't working invalid This doesn't seem right needs review Needs code review labels Nov 12, 2021
@amansilla
Copy link
Contributor Author

Maybe it's a better solution to replace the make ... on the README file with the real commands to be executed, otherwise, we're always dependant on changes done on the standard build Makefile (https://github.com/akeneo/pim-community-dev/blob/master/std-build/Makefile). Let me know what are your thoughts and what solution is preferred so I can implement it if required.

Copy link
Member

@pascal-zarrad pascal-zarrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conclusion to last comment: No changes will be made.

LGTM 👍

@elias-knodel
Copy link
Contributor

@plel @flagbird Should we merge this before the Akeneo v6 Update? (#75)

Copy link

@plel plel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has not real impact so we can merge it.

@amansilla amansilla merged commit 43c692f into master Oct 11, 2022
@amansilla amansilla deleted the fix_installation_guide branch October 11, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right needs review Needs code review size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Akeneo 5 installation guide
4 participants