Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Akeneo 6 support #75

Merged
merged 7 commits into from
Oct 28, 2022
Merged

Add Akeneo 6 support #75

merged 7 commits into from
Oct 28, 2022

Conversation

elias-knodel
Copy link
Contributor

Description

This Pull Request adds support for the newest Akeneo 6 version.

Related issue

Resolves #73
Resolves #74

How can this be tested?

  • Installation on an Akeneo v6 instance should work without issues.
  • Automatic tests should pass

@elias-knodel elias-knodel added the enhancement New feature or request label Oct 10, 2022
@elias-knodel elias-knodel self-assigned this Oct 10, 2022
@elias-knodel elias-knodel force-pushed the feature/akeneo-6 branch 9 times, most recently from b84a892 to b2de539 Compare October 10, 2022 14:57
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 10, 2022
@elias-knodel elias-knodel force-pushed the feature/akeneo-6 branch 4 times, most recently from 87647f6 to 2c0b924 Compare October 19, 2022 12:24
@elias-knodel elias-knodel force-pushed the feature/akeneo-6 branch 2 times, most recently from 67fedb6 to e9dd460 Compare October 25, 2022 13:18
@elias-knodel elias-knodel marked this pull request as ready for review October 25, 2022 13:18
@elias-knodel elias-knodel force-pushed the feature/akeneo-6 branch 3 times, most recently from 1291f65 to 8857aa5 Compare October 25, 2022 13:42
.scrutinizer.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@flagbird flagbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update Code-Sniffer. Their php constraint doesn't look promising.

@elias-knodel elias-knodel force-pushed the feature/akeneo-6 branch 3 times, most recently from 0be28ad to 8070545 Compare October 27, 2022 10:10
@flagbird
Copy link
Collaborator

Scrutinizer seems to use its own composer file. It can be handled with the Scrutinizer config: https://scrutinizer-ci.com/docs/tools/php/code-sniffer/

@elias-knodel elias-knodel force-pushed the feature/akeneo-6 branch 5 times, most recently from f9e09c2 to b9b42ea Compare October 27, 2022 11:59
@elias-knodel elias-knodel merged commit cf7b988 into master Oct 28, 2022
@elias-knodel elias-knodel deleted the feature/akeneo-6 branch October 28, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for akeneo 6 Compatibility with 6.0
3 participants