-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Akeneo 6 support #75
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b84a892
to
b2de539
Compare
b2de539
to
c7d73d8
Compare
87647f6
to
2c0b924
Compare
67fedb6
to
e9dd460
Compare
1291f65
to
8857aa5
Compare
mralexandernickel
requested changes
Oct 25, 2022
d70f8f1
to
812909e
Compare
flagbird
requested changes
Oct 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update Code-Sniffer. Their php constraint doesn't look promising.
0be28ad
to
8070545
Compare
Scrutinizer seems to use its own composer file. It can be handled with the Scrutinizer config: https://scrutinizer-ci.com/docs/tools/php/code-sniffer/ |
f9e09c2
to
b9b42ea
Compare
b9b42ea
to
58de314
Compare
flagbird
approved these changes
Oct 27, 2022
mralexandernickel
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request adds support for the newest Akeneo 6 version.
Related issue
Resolves #73
Resolves #74
How can this be tested?