Appium docs prio one #164
Merged
Appium docs prio one #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonbyrne, @johnsickels, and/or @kbabcock1 please look at this documentation when you have time and let me know if it makes sense or if I should change anything. |
johnsickels
reviewed
Nov 11, 2021
tests/src/appium/smoke.ts
Outdated
| const response = context.response as AppiumResponse; | ||
| const hello = await context.findAll("id/pager_signin_button"); | ||
| context.assert(hello[0]).exists(); | ||
| context.assert(hello).exists(); |
There was a problem hiding this comment.
This could produce a false positive. findAll returns Promise<iValue[]> which is truthy, even if the array is empty and returns no elements found.
A better assertion for findAll would be
context.assert(hello.length).greaterThan(0);
There was a problem hiding this comment.
Can you fix this one as well
context.assert(hello).exists();
johnsickels
reviewed
Nov 11, 2021
johnsickels
reviewed
Nov 11, 2021
johnsickels
reviewed
Nov 11, 2021
johnsickels
reviewed
Nov 11, 2021
tests/src/appium/smoke.ts
Outdated
| const response = context.response as AppiumResponse; | ||
| const hello = await context.findAll("id/pager_signin_button"); | ||
| context.assert(hello[0]).exists(); | ||
| context.assert(hello).exists(); |
There was a problem hiding this comment.
Can you fix this one as well
context.assert(hello).exists();
johnsickels
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation about Appium scenarios, elements, responses, and assertion contexts. Also added tests for Appium.