Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Node version in Docker image #11

Closed
javlund opened this issue Dec 12, 2019 · 3 comments
Closed

Node version in Docker image #11

javlund opened this issue Dec 12, 2019 · 3 comments

Comments

@javlund
Copy link
Contributor

javlund commented Dec 12, 2019

Hi guys, is there a reason you're using the "regular" 300+ MB node Docker image instead of the ~36 MB node alpine image? Otherwise I think that would be a better choice. And perhaps upgrade to node 12 or 13 at the same time.

I'd love to make a PR if you want me to.

@dabeeeenster
Copy link
Contributor

Yep there's lots of work to do around Docker optimisation etc on the project - would welcome any PRs! Thanks.

@javlund
Copy link
Contributor Author

javlund commented Dec 12, 2019

That was a swift reply! Here's a pull request: #12

@kyle-ssg
Copy link
Member

Closed as this was merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants