Gh 2118 return predictions during evaluation #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evaluation # Conflicts: # flair/models/text_classification_model.py
…ns-during-evaluation' into flairNLPGH-2118-return-predictions-during-evaluation # Conflicts: # flair/models/text_classification_model.py
Problem in the new way of returning predictions: the predictions are only contained in sentences if it was chosen memory_mode="full" during creation of the ClassificationDataset in the ClassificationCorpus creation. If the ClassificationCorpus has memory mode "partial", then the predicted labels are not contained in sentences in any case so the following optional removal has no effect. Predictions won't be accessible outside the eval routine in this case regardless whether return_predictions is True or False. TODO: fix this
|
@MLDLMFZ thanks for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the evaluate method of models, give the option to return the predictions obtained on the eval data