Fix/plugin flags #108
Merged
Fix/plugin flags #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwoolvett
force-pushed
the
fix/plugin_flags
branch
from
8c8f54a
to
dbff62c
Compare
pwoolvett
force-pushed
the
fix/plugin_flags
branch
2 times, most recently
from
206e35f
to
943330c
Compare
pwoolvett
force-pushed
the
fix/plugin_flags
branch
from
943330c
to
60c020d
Compare
This fix allows to use the same names in toml configuration files as those from flake8. Before this, values in the main `flakeheaven` section of the config file required using the configuration name (as in `flake8.options.manager.Option.configuration_name`). For example, setting `max-doc-length` (with hyphens) had no effect on `W505` when using flakeheaven, but worked as intened in plain flake8 using `tox.ini`. With this fix applied, configurations can use the same names from `.ini`-style in the `.toml` config. * Added test validating pycodestyle using `max-line-length` related #103 related #78 fixes #105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT:
This fix allows to use the same names in toml configuration files
as those from flake8.
Before this, values in the main
flakeheavensection of the configfile required using the configuration name (as in
flake8.options.manager.Option.configuration_name). For example,setting
max-doc-length(with hyphens) had no effect onW505whenusing flakeheaven, but worked as intened in plain flake8 using
tox.ini.With this fix applied, configurations can use the same names from
.ini-style in the.tomlconfig.related #103
related #78
fixes #105