fix: Only use initialized game for tests and remove setMount from onGameResize #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanpotter
reviewed
Dec 31, 2022
renancaraujo
approved these changes
Dec 31, 2022
st-pasha
reviewed
Jan 3, 2023
spydon
commented
Jan 5, 2023
st-pasha
reviewed
Jan 7, 2023
packages/flame/test/events/flame_game_mixins/has_draggable_components_test.dart
Outdated
Show resolved
Hide resolved
st-pasha
reviewed
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we used
setMountedinonGameResizethemountedfeature didn't work properly when invoked from for exampleonLoad. This PR makes sure that all tests passes without usingsetMountedinonLoad.Some
GameWidgettests I want a second opinion on, or ideas of how to make those tests better, because when setting mounted explicitly it kind of cheats on part of those tests.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #1351