Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: In ValuerRoute example you can click the transparent area to spawn multiple route #3143

Closed
1 task
steambap opened this issue May 1, 2024 · 3 comments · Fixed by #3145
Closed
1 task

Comments

@steambap
Copy link
Contributor

steambap commented May 1, 2024

What could be improved

ValuerRoute example can be fixed by using a solid background.

Why should this be improved

The example's behavior is incorrect. It shouldn't spawn multiple value route on top of each other.

Risks

No response

More information

https://docs.flame-engine.org/latest/flame/router.html#overlayroute

Other

  • Are you interested in working on a PR for this?
@spydon
Copy link
Member

spydon commented May 2, 2024

I don't understand whether this example is about ValueRoute or OverlayRoute since the description says ValueRoute, but the link is leading to OverlayRoute. The example for the OverlayRoute doesn't include anything that is opening that route and I can't replicate the behavior you are mentioning for the ValueRoute example. However, if you don't want events to bubble down to the layers behind the route, just set the route to opaque as described in the first section of the docs that you linked.

@steambap
Copy link
Contributor Author

steambap commented May 3, 2024

Sorry, I copied the wrong link. I'm talking about ValueRoute.

Screenshot 2024-05-03 at 09 15 23

If you click semi-transparent area, another ValueRoute will popup.

@spydon
Copy link
Member

spydon commented May 3, 2024

Ah right, now I can reproduce it. That route should indeed be opaque.

spydon added a commit that referenced this issue May 3, 2024
)

Fixes #3143 

In the future we should probably add another boolean that controls
whether the events should be able to pass through the route or not,
independent on whether the route below is rendered or not.

---------

Co-authored-by: Renan <6718144+renancaraujo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants