Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Take unmounted adds into consideration #2770

Merged
merged 4 commits into from Sep 24, 2023
Merged

fix: Take unmounted adds into consideration #2770

merged 4 commits into from Sep 24, 2023

Conversation

spydon
Copy link
Member

@spydon spydon commented Sep 24, 2023

Description

The previous fix accidentally didn't take into consideration if the parent was unmounted.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

@spydon spydon merged commit be28a44 into main Sep 24, 2023
7 checks passed
@spydon spydon deleted the spydon/fix-unmounted-adds branch September 24, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renancaraujo renancaraujo renancaraujo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spydon @renancaraujo