Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add collision completed listener #2896
feat: Add collision completed listener #2896
Changes from 15 commits
4b8bdd5
5d42eed
f4ab7b9
76d2970
1216440
e9dba44
d49d3da
05db541
015f9bd
92eb7c5
e6256db
09fec9c
21e8725
362ad63
82b6745
9d74231
834c950
2b9c946
66879ca
8e16121
6b779c2
13b3905
2f9fc20
a9308c9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to manually implement
Listenable
, check https://api.flutter.dev/flutter/foundation/ChangeNotifier-class.htmlThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the suggestion to implement
Listenable
came from you, to avoid the warning about unnecessary overrides. Happy to do whichever you think best.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, now I remember. 🤦♂️
I think it is probably better to go with
with ChangeNotifier
anyways, so that we don't have to do the re-implementation, and then we can just put an ignore lint lint above the overridden method.