Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Initial functionality of flame_devtools #3061

Merged
merged 9 commits into from
Mar 5, 2024
Merged

feat: Initial functionality of flame_devtools #3061

merged 9 commits into from
Mar 5, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented Mar 2, 2024

Description

image

This adds a structure and some basic functionality for the Flame devtools extension.

Later I will add a pre/post-hook for publishing to Melos so that it can build the devtools extension before publishing (and remove the directory afterwards), since it isn't committed to this repository. For now one has to run melos devtools-build before publishing.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

@spydon spydon requested a review from a team March 2, 2024 12:21
ufrshubham
ufrshubham reviewed Mar 2, 2024
View reviewed changes
Copy link
Collaborator

@ufrshubham ufrshubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added some minor comments.

packages/flame/lib/src/devtools_helpers/dev_tools_service.dart Outdated Show resolved Hide resolved
packages/flame/lib/src/devtools_helpers/dev_tools_service.dart Outdated Show resolved Hide resolved
renancaraujo
renancaraujo approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@renancaraujo renancaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool

packages/flame_devtools/lib/widgets/component_counter.dart Outdated Show resolved Hide resolved
packages/flame_devtools/.gitignore Outdated Show resolved Hide resolved
erickzanardo
erickzanardo approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits, but LGTM

packages/flame/lib/src/devtools/connectors/component_count_connector.dart Outdated Show resolved Hide resolved
packages/flame/lib/src/devtools/connectors/game_loop_connector.dart Show resolved Hide resolved
@spydon @erickzanardo
Update packages/flame/lib/src/devtools/connectors/component_count_con…
9c8f499 
…nector.dart

Co-authored-by: Erick <erickzanardoo@gmail.com>
@spydon spydon merged commit c92910c into main Mar 5, 2024
8 checks passed
@spydon spydon deleted the feat/flame_devtools branch March 5, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

@renancaraujo renancaraujo renancaraujo approved these changes

@ufrshubham ufrshubham ufrshubham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spydon @erickzanardo @renancaraujo @ufrshubham