Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed export of parser.dart #25

Merged
merged 3 commits into from
Aug 3, 2021
Merged

Fixed export of parser.dart #25

merged 3 commits into from
Aug 3, 2021

Conversation

supagu
Copy link
Contributor

@supagu supagu commented Jun 13, 2021

PR to fix issue #24

@supagu supagu mentioned this pull request Jun 14, 2021
Closed
@supagu
Copy link
Contributor Author

supagu commented Jul 25, 2021

Can we get this test re-run and then merged as I have made fixes to this

luanpotter
luanpotter approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I intended to make the impl private but that file clearly also has the interface and exceptions which can be necessary

@luanpotter luanpotter merged commit 88599a6 into flame-engine:main Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@luanpotter luanpotter luanpotter approved these changes

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@supagu @spydon @luanpotter