Open in external application (a.k.a App Launcher) closes immediately

[mmahmoudian]

Flameshot Version

Flameshot v11.0.0 (03af9d8)

Installation Type

User repository (AUR)

Operating System type and version

Manjaro KDE (Kernel: 5.15.32-1-MANJARO x86_64)

Description

Regardless having the daemon running or not, the App Launcher window immediately closes. This might be related to #2509, but the major difference is that in the case of this issue, the tray icon does not misbehave.

Steps to reproduce

0. Try once with the daemon and once without
1. flameshot gui
2. select some region
3. press the App Launcher button
4. if the App Launcher window opens for a fraction of a second and closes immediately

Screenshots or screen recordings

Peek.2022-04-22.13-24.mp4

System Information

❯ inxi --system --graphics --width=80
System:
  Host: precisiontower Kernel: 5.15.32-1-MANJARO arch: x86_64 bits: 64
    Desktop: KDE Plasma v: 5.24.4 Distro: Manjaro Linux
Graphics:
  Device-1: Intel CometLake-S GT2 [UHD Graphics 630] driver: i915 v: kernel
  Device-2: AMD Lexa XT [Radeon PRO WX 3200] driver: amdgpu v: kernel
  Display: x11 server: X.Org v: 1.21.1.3 driver: X:
    loaded: amdgpu,modesetting gpu: amdgpu resolution: 1: 1920x1080~60Hz
    2: 1080x1920~60Hz 3: 1080x1920~60Hz
  OpenGL: renderer: AMD Radeon Pro WX 3200 Series (POLARIS12 DRM 3.42.0
    5.15.32-1-MANJARO LLVM 13.0.1)
    v: 4.6 Mesa 21.3.8

[LordMZTE]

I'm also getting this on arch with the flameshot packge from the arch repos.

[lommes]

Same for me, built from source (0870eca and earlier), but works when I use "Take Screenshot" from the context menu of the app indicator in gnome 42 (problem already existed in 41)

[ramseyrashid]

I'm experiencing the same on Ubuntu 22.04. I tried the build from apt, snap and latest RC. All do the same as noted above.

[Alaskra]

I find it's #2003 that cause the problem using git bisect. I'm now trying to fix it. @mmahmoudian

[Alaskra]

flameshot/src/main.cpp

Lines 48 to 57 in 0870eca

	void requestCaptureAndWait(const CaptureRequest& req)
	{
	Flameshot* flameshot = Flameshot::instance();
	flameshot->requestCapture(req);
	QObject::connect(flameshot, &Flameshot::captureTaken, [&](QPixmap) {
	// Only useful on MacOS because each instance hosts its own widgets
	if (!FlameshotDaemon::isThisInstanceHostingWidgets()) {
	qApp->exit(0);
	}
	});

The problem is: on click applaunch button, the captureTaken signal emit and flameshot exit before choosing app to launch. I want to take applaunch as exportTask and an Final Action(for example, flameshot gui --applaunch). Is this ok?

[mmahmoudian]

@Alaskra thanks for following the case. To me it makes sense to be a final action, but then I wonder what will happen when the screenshot is taken with --applauncher argument? Does it open a window to choose, or that argument takes a software name/binary path as input? I think this should be discussed (@borgmanJeremy @veracioux )

[borgmanJeremy]

The main reason adding it as an argument might be complicated is "open with" is only support on Linux. I think we should be able to solve the issue with it exiting without making it a final action.

[Alaskra]

The only way I find to solve this issue is adding launchapp to export task, and I find in code that all export task are final actions, so I want to make it final action at the same time.

[Alaskra]

#2617
I find add launchapp to final action useless for this problem. And if it's necessary to add it to final application, I'm happy to contribute code.