fix issue about externalWidget launchapp #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for test @adem4ik ! Maybe capture from launcher is another case. There is no cli entry for capture in windows, so I think the possibility of bug is low. |
borgmanJeremy
approved these changes
Jun 29, 2022
panpuchkov
pushed a commit
to namecheap/flameshot
that referenced
this pull request
Sep 9, 2022
(cherry picked from commit 44b19a9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to introduce other bug when fixed bug #2562 . The first one is the hack that open and close window to trigger exit. It will mess window size in window manager like dwm, so I replace the hack with exit flameshot directly. But I make a mistake so it also close the daemon. This time I add the daemon judge logic, and put it in
captureTaken's slot under the MAC_OS code to keep consistent.