Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win: Fix the WIN64 macro usage #1134

Merged
merged 1 commit into from
Oct 7, 2021
Merged

win: Fix the WIN64 macro usage #1134

merged 1 commit into from
Oct 7, 2021

Conversation

kaadam
Copy link
Collaborator

@kaadam kaadam commented Sep 14, 2021

No description provided.

@kiranchandramohan
Copy link
Collaborator

There is another usage in Line 383. Can you fix that too?

@kaadam
Copy link
Collaborator Author

kaadam commented Sep 15, 2021

There is another usage in Line 383. Can you fix that too?

Yes, I forgot that, thanks Kiran. I upload a new one.

@xoviat
Copy link
Collaborator

xoviat commented Sep 15, 2021

sorry folks, have been a bit busy. I will look at some pull requests this weekend.

@kaadam
Copy link
Collaborator Author

kaadam commented Sep 16, 2021

@kiranchandramohan I've updated the PR, it fixes the all wrong predefined Windows related macros.

@kaadam
Copy link
Collaborator Author

kaadam commented Sep 22, 2021

@kiranchandramohan @xoviat @isuruf could you look at this PR again?

@kaadam
Copy link
Collaborator Author

kaadam commented Oct 5, 2021

@kiranchandramohan ping?

bryanpkc
bryanpkc approved these changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@bryanpkc bryanpkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kaadam
Copy link
Collaborator Author

kaadam commented Oct 7, 2021

@isuruf Could you look at this?

@kiranchandramohan kiranchandramohan merged commit cbb6627 into flang-compiler:master Oct 7, 2021
@kaadam kaadam deleted the win_macro branch October 11, 2021 13:35
@kaadam kaadam added the windows Add this to all windows specific issues or PRs label Oct 18, 2021
@kaadam kaadam mentioned this pull request Oct 19, 2021
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf approved these changes

@bryanpkc bryanpkc bryanpkc approved these changes

@pawosm-arm pawosm-arm pawosm-arm approved these changes

@kiranchandramohan kiranchandramohan Awaiting requested review from kiranchandramohan

Assignees
No one assigned
Labels
windows Add this to all windows specific issues or PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kaadam @kiranchandramohan @xoviat @isuruf @bryanpkc @pawosm-arm