[Runtime] Move init_nomp.c to flangrti #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeixinQiao
requested review from
bryanpkc,
kiranchandramohan,
pawosm-arm and
shivaramaarao
pawosm-arm
approved these changes
Aug 12, 2022
There was a problem hiding this comment.
I was trying to google some reference to those functions, seems it's part of libpgc library shipped with PGI's compiler, e.g. _mp_avlcpus is listed here: https://mailman.ucar.edu/pipermail/met_help/2009-January/000534.html
Although this seems like polluting of flangrti with unrelated stuff, I guess there is no other way to make an improvement. I'm approving this conditionally, assuming other reviewers will also approve this.
bryanpkc
approved these changes
Aug 12, 2022
The functions in init_nomp.c was added in libompstub.so. The ompstub linking "-lompstub" is planned to be removed in the driver. However, it is unknown how the functions in init_nomp.c are used. For example, as the description in ilmtp.n, "_mp_lcpu2" is used for sections directive, but there is no such runtime function generated for a OpenMP sections program. To be safe, move init_nomp.c to flangrti.
PeixinQiao
force-pushed
the
move-init_nomp
branch
from
c475eaf
to
478b5c8
Compare
Thanks. Fixed. |
|
ping @shivaramaarao |
shivaramaarao
approved these changes
Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions in init_nomp.c was added in libompstub.so. The ompstub
linking "-lompstub" is planned to be removed in the driver. However, it
is unknown how the functions in init_nomp.c are used. For example, as
the description in ilmtp.n, "_mp_lcpu2" is used for sections directive,
but there is no such runtime function generated for a OpenMP sections
program. To be safe, move init_nomp.c to flangrti.