Updating the test script to work with python 3.x #918
Conversation
shivaramaarao
requested review from
kiranchandramohan,
gklimowicz and
bryanpkc
shivaramaarao
force-pushed
the
shivaram_fixes
branch
from
cc8a677
to
803411f
Compare
| @@ -101,7 +102,7 @@ def getLogErrors(log): | |||
| elif terminatedError.search(line): | |||
| terminated = True | |||
| else: | |||
| print line, | |||
| sys.stdout.write (line) | |||
There was a problem hiding this comment.
Not a python expert but wouldn't we lose the space between printed lines if we directly use sys.stdout.write?
There was a problem hiding this comment.
The original Python 2 statement print line, with a trailing comma, would have skipped the newline. sys.stdout.write gives the same behavior, and works with both Python 2 and 3.
There was a problem hiding this comment.
Newline is fine and it works with both 2 and 3. The question is about space.
I was trying the python program below and with python 2 it gave the following output. Where the print with comma added space but sys.stdout.write does not add a space.
one two three
onetwothree
import sys
mylist = ["one", "two", "three"]
for l in mylist:
print l,
print ""
for l in mylist:
sys.stdout.write(l)
There was a problem hiding this comment.
yes. this may be a problem and print (line, endl=" ") is the correct code for python 3.x.
Looks like I need to add additional sys.stdout.write(" ") line. would that be fine?
shivaramaarao
force-pushed
the
shivaram_fixes
branch
from
803411f
to
06a6093
Compare
|
Who tested this patch with python2 and python3? |
Hi Steve, I tested with python 2.7 and python 3.6. do you think some more testing need to be done? |
|
@shivaramaarao Hi, that's great. Thanks |
|
I tested on python2 and on python3 (by changing the invocation to use python3 and also setting python3 as alias for python). |
|
I also tested on Power with Python2 and Python3 by changing the scripts that set up the location of the Python executable. |
The script check_compilation.py is written for python 2.x and many tests fail when python 3.x is used.
The print statements used in the script such as print title are not compatible with python 3.x
The script is updated to support both python 2.x and pyton 3.x.