fix: fix config changes filter by cell issues around encoding and colons #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mainawycliffe
force-pushed
the
1970-Changes-Endpoint-Doesnt-Support-URL-Encoded-Values-For-IncludeDecline-Data-such-as-Summary
branch
from
d2f2015
to
d08c018
Compare
mainawycliffe
force-pushed
the
1970-Changes-Endpoint-Doesnt-Support-URL-Encoded-Values-For-IncludeDecline-Data-such-as-Summary
branch
from
d08c018
to
fdeec1a
Compare
mainawycliffe
force-pushed
the
1970-Changes-Endpoint-Doesnt-Support-URL-Encoded-Values-For-IncludeDecline-Data-such-as-Summary
branch
from
fdeec1a
to
47a5a47
Compare
moshloop
force-pushed
the
1970-Changes-Endpoint-Doesnt-Support-URL-Encoded-Values-For-IncludeDecline-Data-such-as-Summary
branch
from
47a5a47
to
3f5c1fd
Compare
|
@mainawycliffe I think the values need to be urlencoded, then combined with a |
mainawycliffe
force-pushed
the
1970-Changes-Endpoint-Doesnt-Support-URL-Encoded-Values-For-IncludeDecline-Data-such-as-Summary
branch
2 times, most recently
from
7e4b97d
to
0fafc19
Compare
|
@moshloop @adityathebe what about instead of a GET request, we use post and body for the filters for this endpoint? This would eliminate the need for double encoding. |
mainawycliffe
force-pushed
the
1970-Changes-Endpoint-Doesnt-Support-URL-Encoded-Values-For-IncludeDecline-Data-such-as-Summary
branch
from
0c7d8ff
to
8d0f45b
Compare
mainawycliffe
force-pushed
the
1970-Changes-Endpoint-Doesnt-Support-URL-Encoded-Values-For-IncludeDecline-Data-such-as-Summary
branch
from
8d0f45b
to
1491d2d
Compare
mainawycliffe
force-pushed
the
1970-Changes-Endpoint-Doesnt-Support-URL-Encoded-Values-For-IncludeDecline-Data-such-as-Summary
branch
from
1491d2d
to
fd48a4a
Compare
mainawycliffe
force-pushed
the
1970-Changes-Endpoint-Doesnt-Support-URL-Encoded-Values-For-IncludeDecline-Data-such-as-Summary
branch
from
fd48a4a
to
1dd909f
Compare
mainawycliffe
force-pushed
the
1970-Changes-Endpoint-Doesnt-Support-URL-Encoded-Values-For-IncludeDecline-Data-such-as-Summary
branch
from
1dd909f
to
a9d6d22
Compare
Fixes #1970 fix: switch to post for catalog changes, instead of get fix: envode value and symbol fix: incorrect encoding issues
mainawycliffe
force-pushed
the
1970-Changes-Endpoint-Doesnt-Support-URL-Encoded-Values-For-IncludeDecline-Data-such-as-Summary
branch
from
a9d6d22
to
e0afae5
Compare
moshloop
deleted the
1970-Changes-Endpoint-Doesnt-Support-URL-Encoded-Values-For-IncludeDecline-Data-such-as-Summary
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1970
Fixes #2017