Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes Endpoint Doesn't Support URL Encoded Values For Include/Decline Data such as Summary #1970

Closed
mainawycliffe opened this issue May 22, 2024 · 2 comments · Fixed by #2012
Closed

Changes Endpoint Doesn't Support URL Encoded Values For Include/Decline Data such as Summary #1970

mainawycliffe opened this issue May 22, 2024 · 2 comments · Fixed by #2012
Assignees
@mainawycliffe
Labels
bug Something isn't working

Comments

@mainawycliffe
Copy link
Contributor

Here is a curl request example, with the summary field being URL encoded as it's value look like this -> status.artifact, status.conditions, for simple string, it works well.

Returns empty response.

http://localhost:3000/api/catalog/changes?summary=status.artifact%252C%2520status.conditions&from=now-2d&to=now&page=1&page_size=200&sort_by=-created_at&recursive=all&depth=1&include_deleted_configs=false
@mainawycliffe mainawycliffe added the bug Something isn't working label May 22, 2024
@mainawycliffe
Copy link
Contributor Author

Related to -> #1931

@adityathebe
Copy link
Member

@mainawycliffe The encoding is incorrect. It looks like it's encoded twice.

@moshloop moshloop transferred this issue from flanksource/mission-control May 30, 2024
mainawycliffe added a commit that referenced this issue Jun 6, 2024
@mainawycliffe
fix: fix config changes filter by cell issues around encoding and colons
d2f2015 
Fixes #1970
@mainawycliffe mainawycliffe mentioned this issue Jun 6, 2024
Merged
mainawycliffe added a commit that referenced this issue Jun 6, 2024
@mainawycliffe
fix: fix config changes filter by cell issues around encoding and colons
d08c018 
Fixes #1970
mainawycliffe added a commit that referenced this issue Jun 7, 2024
@mainawycliffe
fix: fix config changes filter by cell issues around encoding and colons
fdeec1a 
Fixes #1970
mainawycliffe added a commit that referenced this issue Jun 13, 2024
@mainawycliffe
fix: fix config changes filter by cell issues around encoding and colons
47a5a47 
Fixes #1970
moshloop pushed a commit that referenced this issue Jun 13, 2024
@mainawycliffe @moshloop
fix: fix config changes filter by cell issues around encoding and colons
3f5c1fd 
Fixes #1970
mainawycliffe added a commit that referenced this issue Jun 14, 2024
@mainawycliffe
fix: fix config changes filter by cell issues around encoding and colons
7e4b97d 
Fixes #1970
mainawycliffe added a commit that referenced this issue Jun 14, 2024
@mainawycliffe
fix: fix config changes filter by cell issues around encoding and colons
0fafc19 
Fixes #1970
mainawycliffe added a commit that referenced this issue Jun 14, 2024
@mainawycliffe
fix: fix config changes filter by cell issues around encoding and colons
aeb9428 
Fixes #1970
mainawycliffe added a commit that referenced this issue Jun 18, 2024
@mainawycliffe
fix: fix config changes filter by cell issues around encoding and colons
7d5ec55 
Fixes #1970
mainawycliffe added a commit that referenced this issue Jun 18, 2024
@mainawycliffe
fix: fix config changes filter by cell issues around encoding and colons
e8107b8 
Fixes #1970

fix: switch to post for catalog changes, instead of get

fix: envode value and symbol
mainawycliffe added a commit that referenced this issue Jun 18, 2024
@mainawycliffe
fix: fix config changes filter by cell issues around encoding and colons
a9d6d22 
Fixes #1970

fix: switch to post for catalog changes, instead of get

fix: envode value and symbol

fix: incorrect encoding issues
mainawycliffe added a commit that referenced this issue Jun 18, 2024
@mainawycliffe
fix: fix config changes filter by cell issues around encoding and colons
e0afae5 
Fixes #1970

fix: switch to post for catalog changes, instead of get

fix: envode value and symbol

fix: incorrect encoding issues
moshloop pushed a commit that referenced this issue Jun 19, 2024
@mainawycliffe @moshloop
fix: fix config changes filter by cell issues around encoding and colons
012cfb0 
Fixes #1970

fix: switch to post for catalog changes, instead of get

fix: envode value and symbol

fix: incorrect encoding issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mainawycliffe mainawycliffe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix config changes filter by cell issues around encoding and colons flanksource/flanksource-ui
2 participants
@mainawycliffe @adityathebe