Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more events to be buffered before the backend starts #1352

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

ChenLingPeng
Copy link
Contributor

Signed-off-by: forrestchen forrestchen@tencent.com

Description

Our k8s cluster has more than 5000 nodes, chan with size 5000 will block flannel to run.

related issue: #719

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

@ChenLingPeng
Copy link
Contributor Author

#729 adjust the size to 5000, and it is not enough now.

@rajatchopra
Copy link
Contributor

Should we make this configurable?
Through cli or env var, to the container in kube-flannel.yml daemonset.
Or, eventually when flannel has a helm chart based installation.

@ChenLingPeng
Copy link
Contributor Author

@rajatchopra PR updated, please take a review

@luthermonson luthermonson self-requested a review March 18, 2021 15:55
@luthermonson luthermonson self-requested a review March 18, 2021 15:56
subnet/kube/kube.go Outdated Show resolved Hide resolved
Signed-off-by: forrestchen <forrestchen@tencent.com>
subnet/kube/kube.go Outdated Show resolved Hide resolved
@manuelbuil
Copy link
Collaborator

@ChenLingPeng will you have time to address the review?

@ChenLingPeng
Copy link
Contributor Author

@ChenLingPeng will you have time to address the review?

updated, PTAL

@luthermonson luthermonson requested review from rajatchopra and rbrtbnfgl and removed request for rajatchopra April 14, 2022 15:48
@luthermonson luthermonson merged commit 349feae into flannel-io:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants