Fix etcd key removal in CI and add -e flag #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbrtbnfgl
approved these changes
Jun 22, 2022
manuelbuil
force-pushed
the
fix_etcd_rm_CI
branch
5 times, most recently
from
68e4a0e
to
54cab9b
Compare
Signed-off-by: Manuel Buil <mbuil@suse.com>
manuelbuil
force-pushed
the
fix_etcd_rm_CI
branch
from
54cab9b
to
bc23471
Compare
thomasferrandiz
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Buil mbuil@suse.com
Description
This PR fixes the CI problem as described in #1594. It changes the etcdctl command from "rm" to "del" which is the correct one for v3. Then, it adds -e bash flag to make sure this error or future ones are not ignored
Besides, add
--alwaysto git describe or it failsTodos
Release Note