Update iptables-wrapper-installer.sh from upstream #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I've only tested this on v0.14.0. |
|
Thanks for the PR. |
endzyme
force-pushed
the
update-iptables-wrapper-upstream
branch
from
92c2621
to
65ab1dd
Compare
|
All set - and rebased onto mainline. |
|
Anything I need to do here? The linter appears to be failing on files I didn't touch. |
|
Hi |
Downloaded the v2 version of this script which behaves more consistently but reverts back to the old behavior of iptables-save line counting if the other behaviors don't work. Script source: https://raw.githubusercontent.com/kubernetes-sigs/iptables-wrappers/v2/iptables-wrapper-installer.sh SHA: e139a115350974aac8a82ec4b815d2845f86997e Pulled from: https://github.com/kubernetes-sigs/iptables-wrappers
endzyme
force-pushed
the
update-iptables-wrapper-upstream
branch
from
65ab1dd
to
ef3ae5f
Compare
|
@thomasferrandiz all set |
|
Bump |
|
Sorry I missed your previous update. |
thomasferrandiz
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are experiencing problems with the current version of the
iptables-wrapperscript. If you have any processes which are using an older binary for iptables, you can experience issues with Flannel selecting the correct version of iptables when first starting the container. Currently if youriptables-legacy-saveoutput is greater than or equal to the output ofiptables-nft-savethen the container will select using the legacy table. The new behavior, which is supported in Kubernetes 1.17+ will look for some special table names in iptables, provided by kubelet, and if they are not found then will revert to line counting. This yields a more consistent experience with iptables version selection.Change: Download the v2 version of this script which behaves more consistently but reverts back to the old behavior of iptables-save line counting if the other behaviors don't work.
Script source: https://raw.githubusercontent.com/kubernetes-sigs/iptables-wrappers/v2/iptables-wrapper-installer.sh
SHA: e139a115350974aac8a82ec4b815d2845f86997e
Pulled from: https://github.com/kubernetes-sigs/iptables-wrappers
Todos
Release Note