Add a check when reading the config #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Buil <mbuil@suse.com>
manuelbuil
force-pushed
the
checkingConfig
branch
from
409e1f7
to
861c965
Compare
rbrtbnfgl
approved these changes
Aug 29, 2022
thomasferrandiz
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Buil mbuil@suse.com
Description
If the user does not include the Network or IPv6Network parameters in the config, flannel fails without a useful error and it often breaks the network of the host. Therefore, we should check that these parameters exist in case ipv4 or ipv6 was enabled
Todos
Release Note