Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added additional check for n.spec.podCIDRs #1890

Merged
merged 1 commit into from Mar 1, 2024
Merged

Added additional check for n.spec.podCIDRs #1890

merged 1 commit into from Mar 1, 2024

Conversation

rbrtbnfgl
Copy link
Contributor

Description

Added additional chek to verify that n.spec.podCIDRs is rightly configured on the node

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

@rbrtbnfgl
Added additional check for n.spec.podCIDRs
6794631 
Signed-off-by: Roberto Bonafiglia <roberto.bonafiglia@suse.com>
@manuelbuil
Copy link
Collaborator

Did you find a config where this happens?

@rbrtbnfgl
Copy link
Contributor Author

Here k3s-io/k3s#9569
It shouldn't happen when flannel runs as a pod because the check is done before. When using K3s that directly calls the flannel function it misses the other checks.

@thomasferrandiz thomasferrandiz merged commit ee53746 into flannel-io:master Mar 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelbuil manuelbuil manuelbuil approved these changes

@thomasferrandiz thomasferrandiz thomasferrandiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rbrtbnfgl @manuelbuil @thomasferrandiz