Bug fixes

[thomasferrandiz]

• show content of stdout and stderr when running iptables-restore returns an error
• fix comparison with previous networks in SetupAndEnsureMasqRules
• add empty WindowsTrafficManager to make logs clearer

Related issue: #1939

[manuelbuil]

Instead of doing this and creating a new file, why don't you just increase the verbosity required for the ErrUnimplemented error to be logged and return nil? I think this is too much just to make the logs clearer

[thomasferrandiz]

My reasoning is that in this way I never display the "Starting flannel in iptables mode" message which was confusing users.
Also I hoped that it would allow me to delete the iptables_windows.go file but it's still needed to compile on windows.

I was also thinking since we have more requests for flannel on windows there could at some point be something to do in the windows traffic manager even it does't use iptables or nftables.

[manuelbuil]

My main problem is that I find it confusing having so many windows files around. Why can't we remove iptables-_windows.go and nftables_windows.go?

I don't think we will ever need Windows doing anything around traffic manager because the forwarding is always there and the natting is also default when creating the overlay network.

[thomasferrandiz]

If we remove those files then the windows builds fail because all the other files in the package have this constraint:

//go:build !windows
// +build !windows

I have another idea though: instead of having a dedicated windows package which does nothing, I can move the log line inside the traffic manager Init methds so that the log can be different based on the OS.

[manuelbuil]

good idea!