Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Go 1.16 #324

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Migrate to Go 1.16 #324

merged 1 commit into from
Oct 13, 2021

Conversation

diafour
Copy link
Contributor

@diafour diafour commented Oct 5, 2021 •
edited
Loading

Overview

Migrate to Go 1.16

What this PR does / why we need it

  • Update go-openapi to fix 1.16 incompatibility
  • Remove kind dependency, use kind as a cli utility to start a cluster for e2e tests.
  • Use kubectl 1.19.11
  • Use alpine 3.14

Special notes for your reviewer

go-openapi/validate is replaced with a forked version with 2 patches:

  • remove 'in body' from errors
  • fix Go 1.16 problem

Does this PR introduce a user-facing change?

- kubectl 0.19.11
- alpine 3.14

@diafour diafour added publish/image/dev Build and push dev image using PR number as docker tag run/tests Run tests on full matrix of k8s versions labels Oct 5, 2021
@github-actions github-actions bot removed publish/image/dev Build and push dev image using PR number as docker tag run/tests Run tests on full matrix of k8s versions labels Oct 5, 2021
@diafour diafour added the run/tests Run tests on full matrix of k8s versions label Oct 6, 2021
@github-actions github-actions bot removed the run/tests Run tests on full matrix of k8s versions label Oct 6, 2021
@diafour
ref: migrate to Go 1.16
3811f54 
- use kind as gh actions
- update go-openapi libraries
- update kubectl and alpine
@diafour diafour merged commit bfe409c into master Oct 13, 2021
@diafour diafour mentioned this pull request Oct 13, 2021
Merged
@diafour diafour added this to the 1.0.4 milestone Oct 18, 2021
@diafour diafour deleted the migrate_to_go_1_16 branch December 1, 2021 17:25
@diafour diafour mentioned this pull request Feb 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabokihms nabokihms nabokihms approved these changes

@yalosev yalosev Awaiting requested review from yalosev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@diafour @nabokihms