improve notification routing doc 2 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ali-graham and @Hobbsee your feedback on this would be appreciated |
|
Hmm, I hadn't seen Github's image diff-er before... nice! Yup, looks good. |
| 2. Run this shell: | ||
| 1. **Receive events.** | ||
| * Events are generated by external check execution systems and created as json objects in the `events` queue in Redis. | ||
| * Processor removes events off the queue and, astonishingly, processes them one by one. |
There was a problem hiding this comment.
The tense on this line doesn't match the rest of the document, and astonishingly probably isn't needed.
There was a problem hiding this comment.
it's current tense, like the rest of the document. am I missing something?
|
That's a really nice gif, and I learned some stuff around this today. Thanks, @necula01 & @jessereynolds! |
jessereynolds
added a commit
that referenced
this pull request
May 26, 2015
…_routing_doc improve notification routing doc 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #21 but with some additional commits.