Changes from PR1. Scrubbed notebook outputs, incorporated lax looping… #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… function, and cosmetic changes to notebook 2.
|
Thanks a lot Simon! I have indeed noticed it too that using Anyway thanks for this PR! And... always welcome to add new stuff in the future 😉 [closes #1 ] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… function, and cosmetic changes to notebook 2.
Thanks for the feedback!
Good calls on notebook outputs -- here's a clean history without them. On my end with GPU the lax function is faster to compile, but seems slower to execute (by a factor of ~6).