Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add debug button in AJAX errors #1687

Closed
jordanjay29 opened this issue Dec 7, 2018 · 7 comments · Fixed by #1906
Closed

Re-add debug button in AJAX errors #1687

jordanjay29 opened this issue Dec 7, 2018 · 7 comments · Fixed by #1906

Comments

@jordanjay29
Copy link
Contributor

Removed in 64686ef for Beta 8.

However, this is a much easier method of debugging for support requests, and does not force users to learn a new UI (web/dev tools in browser) or parse which errors in log files are relevant immediately.

I suggest restoring it for future versions.

@tobyzerner tobyzerner added this to the 0.1.0-beta.9 milestone Dec 7, 2018
@franzliedke
Copy link
Contributor

We discussed this and decided to also add the error message to the console output, to have them persisted when the modal is gone.

@tobyzerner tobyzerner changed the title Beta 8 removes debug link in errors Re-add debug button in AJAX errors Dec 8, 2018
@MichaelBelgium
Copy link

MichaelBelgium commented Dec 8, 2018

I've always used that button to see my var_dump's , but now there's no way to see it. Althought It did show plain html code, maybe let it support html too? Or there could be another way possibly.

@dsevillamartin
Copy link
Member

@MichaelBelgium Instead of using var_dump, use Flarum's logger with app('log'). You can emit debug messages with app('log')->debug(...), info with app('log')->info(...), etc...
You can find those log files in storage/logs

@MichaelBelgium
Copy link

@datitisev ooh great didn't know about that!

@luceos
Copy link
Member

luceos commented Jul 12, 2019

maybe promote issues like these on a dev diary: https://discuss.flarum.org/d/20605-dev-diary-beta-10

@cmcjacob
Copy link

cmcjacob commented Aug 29, 2019

Is this on the beta10 roadmap? I had to manually add the debug button back and would also like to see this feature return. Also curious as to why it was removed in the first place.

@franzliedke
Copy link
Contributor

It is currently targeted for beta10, but might not make the cut. Unless somebody sends a PR. 😉

As for why it was removed, the commit says:

Using the browser's console to debug failed requests is much more powerful

That's definitely true, but probably quite overwhelming for non-technical users.

@Ralkage Ralkage modified the milestones: 0.1.0-beta.10, 0.1.0-beta.11 Sep 10, 2019
dsevillamartin pushed a commit that referenced this issue Nov 9, 2019
luceos pushed a commit that referenced this issue Feb 4, 2020
wzdiyb pushed a commit to wzdiyb/core that referenced this issue Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants