feat: re-add debug button/modal #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think, even though we didn't include it in the issue comments, that we also wanted to log the error ( I didn't look at your implementation, but is it basically the same as how it was before? |
|
Yes, it is exactly the same old implementation – no code changes. I will take a look into the console debug output next week and update this PR accordingly. |
dsevillamartin
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1687
Changes proposed in this pull request:
Reintroduce the debug button in error modals, which was removed in 64686ef
Screenshot
Confirmed
Required changes:
No tests or documentation changes needed (I guess?)