Fix search box out of screen #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SychO9
reviewed
Mar 2, 2021
askvortsov1
force-pushed
the
as/fix-search-box-out-of-screen
branch
from
0790816
to
1a631c2
Compare
SychO9
reviewed
Mar 5, 2021
SychO9
approved these changes
Mar 7, 2021
clarkwinkelmann
approved these changes
Mar 7, 2021
There was a problem hiding this comment.
Tested locally (with desktop tools) and seems to work well.
It does not react to window.onresize though, so being in oncreate or onupdate probably won't change anything if the browser resizes due to keyboard. It's however a good thing in case it needs updating while you type additional things.
askvortsov1
added a commit
that referenced
this pull request
Apr 9, 2021
Identified as a potential issue in #2650 When typing, the keyboard generally obstructs half the screen. However, when the keyboard is closed, search results don't expand to take up full space.
askvortsov1
added a commit
that referenced
this pull request
Apr 19, 2021
Identified as a potential issue in #2650 When typing, the keyboard generally obstructs half the screen. However, when the keyboard is closed, search results don't expand to take up full space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2621
Changes proposed in this pull request:
Set search results max height programatically instead of relying on 70vh, as elements like fof links might mess this up.